Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering: when a string contains \, automatically change to """ #116

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

mpollmeier
Copy link
Owner

So that we don't need to escape it and it can be easily copy-pasted.

Old behaviour:

scala> """foo\bar"""
val res0: String = "foo\\bar"

New behaviour:

scala> """foo\bar"""
val res0: String = """foo\bar"""

Will suggest to fansi upstream.
Special thanks to @maltek for noticing and suggesting.

So that we don't need to escape it and it can be easily copy-pasted.

Old behaviour:
```scala
scala> """foo\bar"""
val res0: String = "foo\\bar"
```

New behaviour:
```scala
scala> """foo\bar"""
val res0: String = """foo\bar"""
```

Will suggest to fansi upstream.
Special thanks to @maltek for noticing and suggesting.
@mpollmeier mpollmeier requested a review from maltek September 5, 2023 13:41
@mpollmeier
Copy link
Owner Author

upstream PR: com-lihaoyi/PPrint#110

@mpollmeier mpollmeier merged commit 2dac2d2 into main Sep 5, 2023
3 checks passed
@max-leuthaeuser max-leuthaeuser deleted the pprinter/render-backslash-without-escaping branch August 2, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants